Skip to content

Fix Exception in list static filter index assumptions#1120

Merged
JakenVeina merged 9 commits into
reactivemarbles:mainfrom
jcummings2:fix-removekey-list-static-filter-index-assumptions
Jul 4, 2026
Merged

Fix Exception in list static filter index assumptions#1120
JakenVeina merged 9 commits into
reactivemarbles:mainfrom
jcummings2:fix-removekey-list-static-filter-index-assumptions

Conversation

@jcummings2

Copy link
Copy Markdown
Contributor

See #1119

Comment thread src/DynamicData.Tests/Cache/RemoveKeyFixture.cs Outdated
Comment thread src/DynamicData.Tests/Cache/RemoveKeyFixture.cs
Comment thread src/DynamicData/List/Internal/Filter.Static.cs Outdated
Comment thread src/DynamicData/List/Internal/Filter.Static.cs
@jcummings2

Copy link
Copy Markdown
Contributor Author

I updated test names and removed the extraneous comment per your feedback. Let me know if those names need further tweaking.

I also added another test that moves the RemoveKey() call to just before the bind. This new test passes even with the old code as it turns out.

@JakenVeina
JakenVeina force-pushed the fix-removekey-list-static-filter-index-assumptions branch from c3967e0 to 7d02d18 Compare July 2, 2026 06:38
@JakenVeina
JakenVeina merged commit d26b63c into reactivemarbles:main Jul 4, 2026
2 checks passed
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants